Commit Graph
4 Commits
Author SHA1 Message Date
dualfroz aa4f462b2e fix: make Buffer::nth() positional so it stays correct after deletions
Buffer::nth() resolved the requested position by adding it to the first row key
and indexing the rows array by that computed key. That assumes contiguous keys,
but Buffer::delete() removes rows with unset() without reindexing, leaving gaps.
After a deletion nth() therefore returned the wrong record (or an empty array for
a valid position, or a record for an out-of-range position). Resolve the position
against the record order with array_values() so nth() matches getRecords() and
ResultSet::nth().
2026-09-04 09:31:11 +02:00
upstream 4354a49e5b Upstream thephpleague/csv state of the touched files before 3426bb277e 2026-09-04 09:31:11 +02:00
dualfroz e77df85d0c fix: make Buffer::nth() positional so it stays correct after deletions
Buffer::nth() resolved the requested position by adding it to the first row key
and indexing the rows array by that computed key. That assumes contiguous keys,
but Buffer::delete() removes rows with unset() without reindexing, leaving gaps.
After a deletion nth() therefore returned the wrong record (or an empty array for
a valid position, or a record for an out-of-range position). Resolve the position
against the record order with array_values() so nth() matches getRecords() and
ResultSet::nth().
2026-09-04 22:00:22 +02:00
upstream 7f690c67cd Upstream thephpleague/csv state of the touched files before 96e3608aa6 2026-09-04 09:31:11 +02:00