fix: reject start-after in ListObjects V1

listobjects v1 now returns InvalidArgument when the start-after query parameter is present, matching s3, which only accepts it with list-type=2. previously the parameter was silently ignored.

Fixes #2004

tests/integration/ListObjects.go

@@ -17,6 +17,8 @@ package integration
 import (
 	"context"
 	"fmt"
+	"net/http"
+	"time"
 
 	"github.com/aws/aws-sdk-go-v2/service/s3"
 	"github.com/aws/aws-sdk-go-v2/service/s3/types"
@@ -338,6 +340,33 @@ func ListObjects_marker_not_from_obj_list(s *S3Conf) error {
 	})
 }
 
+// ListObjects_start_after_not_supported sends start-after without
+// list-type=2. S3 rejects it with InvalidArgument instead of ignoring it.
+func ListObjects_start_after_not_supported(s *S3Conf) error {
+	testName := "ListObjects_start_after_not_supported"
+	return actionHandler(s, testName, func(s3client *s3.Client, bucket string) error {
+		_, err := putObjects(s3client, []string{"bar", "foo"}, bucket)
+		if err != nil {
+			return err
+		}
+
+		// ListObjectsInput has no StartAfter field, so send the query directly
+		req, err := createSignedReq(http.MethodGet, s.endpoint,
+			fmt.Sprintf("%v?start-after=bar", bucket),
+			s.awsID, s.awsSecret, "s3", s.awsRegion, "", nil, time.Now(), nil)
+		if err != nil {
+			return err
+		}
+
+		resp, err := s.httpClient.Do(req)
+		if err != nil {
+			return err
+		}
+
+		return checkHTTPResponseApiErr(resp, s3err.GetInvalidArgumentErr(s3err.InvalidArgStartAfter, ""))
+	})
+}
+
 func ListObjects_with_checksum(s *S3Conf) error {
 	testName := "ListObjects_with_checksum"
 	return actionHandler(s, testName, func(s3client *s3.Client, bucket string) error {

tests/integration/group-tests.go

@@ -315,6 +315,7 @@ func TestListObjects(ts *TestState) {
 	ts.Run(ListObjects_delimiter)
 	ts.Run(ListObjects_max_keys_none)
 	ts.Run(ListObjects_marker_not_from_obj_list)
+	ts.Run(ListObjects_start_after_not_supported)
 	ts.Run(ListObjects_list_all_objs)
 	ts.Run(ListObjects_nested_dir_file_objs)
 	ts.Run(ListObjects_check_owner)
@@ -3117,6 +3118,7 @@ func GetIntTests() IntTests {
 		"ListObjects_delimiter":                                                            ListObjects_delimiter,
 		"ListObjects_max_keys_none":                                                        ListObjects_max_keys_none,
 		"ListObjects_marker_not_from_obj_list":                                             ListObjects_marker_not_from_obj_list,
+		"ListObjects_start_after_not_supported":                                            ListObjects_start_after_not_supported,
 		"ListObjects_list_all_objs":                                                        ListObjects_list_all_objs,
 		"ListObjects_nested_dir_file_objs":                                                 ListObjects_nested_dir_file_objs,
 		"ListObjects_check_owner":                                                          ListObjects_check_owner,

tests/test_rest_list_objects.sh

@@ -260,9 +260,6 @@ source ./tests/drivers/objects_and_versions.sh
 
 # tags: curl,ListObjects,start-after,invalid-query
 @test "ListObjectsV1 - start-after - error" {
-  if [ "$DIRECT" != "true" ]; then
-    skip "https://github.com/versity/versitygw/issues/2004"
-  fi
   run setup_bucket_and_files_v3 "$BUCKET_ONE_NAME" 2
   assert_success
   read -r bucket_name file_one file_two <<< "$output"