fix: return MalformedXML for a DeleteObjects request without objects

A DeleteObjects request whose Delete element names no objects was
answered with 200 and an empty DeleteResult. S3 rejects it with
MalformedXML, as the schema requires at least one Object.

Reject the empty list right after the body is parsed, next to the
1000 key limit check. Update the unit and integration tests that
expected the empty result and enable the REST test that covers it.

Fixes #2109

tests/integration/DeleteObjects.go

@@ -49,25 +49,17 @@ func DeleteObjects_empty_input(s *S3Conf) error {
 		}
 
 		ctx, cancel := context.WithTimeout(context.Background(), shortTimeout)
-		out, err := s3client.DeleteObjects(ctx, &s3.DeleteObjectsInput{
+		_, err = s3client.DeleteObjects(ctx, &s3.DeleteObjectsInput{
 			Bucket: &bucket,
 			Delete: &types.Delete{
 				Objects: []types.ObjectIdentifier{},
 			},
 		})
 		cancel()
-		if err != nil {
+		if err := checkApiErr(err, s3err.GetAPIError(s3err.ErrMalformedXML)); err != nil {
 			return err
 		}
 
-		if len(out.Deleted) != 0 {
-			return fmt.Errorf("expected deleted object count 0, instead got %v",
-				len(out.Deleted))
-		}
-		if len(out.Errors) != 0 {
-			return fmt.Errorf("expected 0 errors, instead got %v", len(out.Errors))
-		}
-
 		ctx, cancel = context.WithTimeout(context.Background(), shortTimeout)
 		res, err := s3client.ListObjects(ctx, &s3.ListObjectsInput{
 			Bucket: &bucket,

tests/test_rest_delete_objects.sh

@@ -36,9 +36,6 @@ source ./tests/setup.sh
 
 # tags: curl, DeleteObjects, malformed-message
 @test "REST - DeleteObjects - no objects added to payload" {
-  if [ "$DIRECT" != "true" ]; then
-    skip "https://github.com/versity/versitygw/issues/2109"
-  fi
   run setup_bucket_and_file_v3 "$BUCKET_ONE_NAME"
   assert_success
   read -r bucket_name file_name <<< "$output"