Upstream versity/versitygw state of the touched files before 44dc2e71ec

s3api/controllers/bucket-get.go

@@ -21,9 +21,7 @@ import (
 	"github.com/aws/aws-sdk-go-v2/service/s3/types"
 	"github.com/gofiber/fiber/v3"
 	"github.com/versity/versitygw/auth"
-	"github.com/versity/versitygw/debuglogger"
 	"github.com/versity/versitygw/s3api/utils"
-	"github.com/versity/versitygw/s3err"
 	"github.com/versity/versitygw/s3response"
 )
 
@@ -633,17 +631,6 @@ func (c S3ApiController) ListObjects(ctx fiber.Ctx) (*Response, error) {
 		}, err
 	}
 
-	// start-after belongs to list-type=2 only; S3 rejects it here instead of
-	// ignoring it
-	if ctx.Request().URI().QueryArgs().Has("start-after") {
-		debuglogger.Logf("start-after is not supported in ListObjects V1")
-		return &Response{
-			MetaOpts: &MetaOptions{
-				BucketOwner: parsedAcl.Owner,
-			},
-		}, s3err.GetInvalidArgumentErr(s3err.InvalidArgStartAfter, "")
-	}
-
 	maxkeys, err := utils.ParseMaxLimiter(maxkeysStr, utils.LimiterTypeMaxKeys)
 	if err != nil {
 		return &Response{

s3api/controllers/bucket-get_test.go

@@ -1212,24 +1212,6 @@ func TestS3ApiController_ListObjects(t *testing.T) {
 				err: s3err.GetInvalidArgMaxLimiter(string(utils.LimiterTypeMaxKeys), "bla"),
 			},
 		},
-		{
-			name: "start-after is not supported",
-			input: testInput{
-				locals: defaultLocals,
-				beRes:  listResult,
-				queries: map[string]string{
-					"start-after": "my-key",
-				},
-			},
-			output: testOutput{
-				response: &Response{
-					MetaOpts: &MetaOptions{
-						BucketOwner: "root",
-					},
-				},
-				err: s3err.GetInvalidArgumentErr(s3err.InvalidArgStartAfter, ""),
-			},
-		},
 		{
 			name: "backend returns error",
 			input: testInput{