From 94062cea691e39364a69761f4e86ee71dca1c080 Mon Sep 17 00:00:00 2001
From: DualFroz <me@dualfroz.com>
Date: Sat, 3 Oct 2026 02:27:25 +0200
Subject: [PATCH] fix: use autolinks for URLs that contain an ampersand

The link text goes through TextConverter, which escapes `&` to `&amp;`,
while the href is the decoded attribute value, so `$href === $text` never
held for a URL with a query string like `?a=1&b=2`. Undo that escaping
before comparing. Only `&amp;` is undone: `<` and `>` cannot appear in an
autolink, so those links keep the inline form.

Fixes #248
---
 src/Converter/LinkConverter.php | 2 +-
 tests/HtmlConverterTest.php     | 2 ++
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/Converter/LinkConverter.php b/src/Converter/LinkConverter.php
index f0ba157..2b650a5 100644
--- a/src/Converter/LinkConverter.php
+++ b/src/Converter/LinkConverter.php
@@ -26,7 +26,7 @@ class LinkConverter implements ConverterInterface, ConfigurationAwareInterface
 
         if ($title !== '') {
             $markdown = '[' . $text . '](' . $href . ' "' . $title . '")';
-        } elseif ($href === $text && $this->isValidAutolink($href)) {
+        } elseif ($href === \str_replace('&amp;', '&', $text) && $this->isValidAutolink($href)) {
             $markdown = '<' . $href . '>';
         } elseif ($href === 'mailto:' . $text && $this->isValidEmail($text)) {
             $markdown = '<' . $text . '>';
diff --git a/tests/HtmlConverterTest.php b/tests/HtmlConverterTest.php
index e62247e..dd9bd6d 100644
--- a/tests/HtmlConverterTest.php
+++ b/tests/HtmlConverterTest.php
@@ -163,6 +163,8 @@ class HtmlConverterTest extends TestCase
         $this->assertHtmlGivesMarkdown('<a href="google.com">google.com</a>', '[google.com](google.com)');
         $this->assertHtmlGivesMarkdown('<a href="https://www.google.com">https://www.google.com</a>', '<https://www.google.com>');
         $this->assertHtmlGivesMarkdown('<a href="ftp://files.example.com">ftp://files.example.com</a>', '<ftp://files.example.com>');
+        $this->assertHtmlGivesMarkdown('<a href="https://example.com/?a=1&amp;b=2">https://example.com/?a=1&amp;b=2</a>', '<https://example.com/?a=1&b=2>');
+        $this->assertHtmlGivesMarkdown('<a href="https://example.com/&lt;b&gt;">https://example.com/&lt;b&gt;</a>', '[https://example.com/&lt;b&gt;](https://example.com/<b>)');
         $this->assertHtmlGivesMarkdown('<a href="mailto:test@example.com">test@example.com</a>', '<test@example.com>');
         $this->assertHtmlGivesMarkdown('<a href="mailto:test+foo@example.bar-baz.com">test+foo@example.bar-baz.com</a>', '<test+foo@example.bar-baz.com>');