diff --git a/src/TemporaryDirectory.php b/src/TemporaryDirectory.php index 2fb29dd..c65d938 100644 --- a/src/TemporaryDirectory.php +++ b/src/TemporaryDirectory.php @@ -163,12 +163,7 @@ class TemporaryDirectory protected function isFilePath(string $path): bool { - // Only the last segment can be a filename; a dot in a parent segment would - // misclassify a directory. - $lastSeparator = strrpos($path, DIRECTORY_SEPARATOR); - $lastSegment = $lastSeparator === false ? $path : substr($path, $lastSeparator + 1); - - return str_contains($lastSegment, '.'); + return str_contains($path, '.'); } protected function deleteDirectory(string $path): bool diff --git a/tests/TemporaryDirectoryTest.php b/tests/TemporaryDirectoryTest.php index 4ff79fa..88035fb 100644 --- a/tests/TemporaryDirectoryTest.php +++ b/tests/TemporaryDirectoryTest.php @@ -173,25 +173,6 @@ class TemporaryDirectoryTest extends TestCase $this->assertDirectoryExists("{$this->temporaryDirectoryFullPath}/{$subdirectory}"); } - /** @test */ - public function it_can_create_a_subdirectory_when_the_location_contains_a_dot() - { - $dottedLocation = rtrim(sys_get_temp_dir(), DIRECTORY_SEPARATOR).DIRECTORY_SEPARATOR.'my.dotted.location'; - $this->deleteDirectory($dottedLocation); - - $temporaryDirectory = (new TemporaryDirectory($dottedLocation)) - ->name($this->temporaryDirectory) - ->create(); - - $subdirectory = 'abc'; - $subdirectoryPath = $temporaryDirectory->path($subdirectory); - - $this->assertDirectoryExists($subdirectoryPath); - - $temporaryDirectory->delete(); - $this->deleteDirectory($dottedLocation); - } - /** @test */ public function it_can_create_a_multiple_subdirectories_in_the_temporary_directory() {