Identify archives by content before file name
An archive renamed to another extension, such as a .tar.gz renamed to .zip, was read as a zip inside a gzip stream and failed with "input type must be an io.ReaderAt and io.Seeker". The format is now taken from the contents first, and the file name is only used when they are not recognized. Fixes pterodactyl/panel#5728
This commit is contained in:
1 parent
d8cb044658
commit
e7bb19d447
2 files changed
+41
-2
No files matched your search
@@ -95,7 +95,7 @@ func (fs *Filesystem) SpaceAvailableForDecompression(ctx context.Context, dir st
|
||||
}
|
||||
defer f.Close()
|
||||
|
||||
format, _, err := archives.Identify(ctx, filepath.Base(file), f)
|
||||
format, _, err := identifyArchive(ctx, file, f)
|
||||
if err != nil && !errors.Is(err, archives.NoMatch) {
|
||||
return err
|
||||
}
|
||||
@@ -172,7 +172,7 @@ func (fs *Filesystem) DecompressFile(ctx context.Context, dir string, file strin
|
||||
defer f.Close()
|
||||
|
||||
// Identify the type of archive we are dealing with.
|
||||
format, input, err := archives.Identify(ctx, filepath.Base(file), f)
|
||||
format, input, err := identifyArchive(ctx, file, f)
|
||||
if err != nil {
|
||||
if errors.Is(err, archives.NoMatch) {
|
||||
return newFilesystemError(ErrCodeUnknownArchive, err)
|
||||
@@ -188,6 +188,18 @@ func (fs *Filesystem) DecompressFile(ctx context.Context, dir string, file strin
|
||||
})
|
||||
}
|
||||
|
||||
// identifyArchive identifies the format of an archive by its contents, and only
|
||||
// falls back to its file name when the contents are not recognized. Matching on
|
||||
// the name first reads an archive with the wrong extension, such as a .tar.gz
|
||||
// renamed to .zip, as a zip inside a gzip stream, which cannot be extracted.
|
||||
func identifyArchive(ctx context.Context, file string, f ufs.File) (archives.Format, io.Reader, error) {
|
||||
format, input, err := archives.Identify(ctx, "", f)
|
||||
if errors.Is(err, archives.NoMatch) {
|
||||
return archives.Identify(ctx, filepath.Base(file), f)
|
||||
}
|
||||
return format, input, err
|
||||
}
|
||||
|
||||
// ExtractTransfer extracts the archive of a server that is being transferred to
|
||||
// this node into the server's directory. Every file is kept, including ones the
|
||||
// denylist would refuse, since they are the server's own files.
|
||||
|
||||
Reference in new issue
Block a user