From 9b1e7d66ce4902d8fe220c9150041a9fa82df6aa Mon Sep 17 00:00:00 2001 From: Michal Fox Date: Sat, 3 Oct 2026 01:25:27 +0200 Subject: [PATCH] acme: domain edit: allow setting the alias of DNS domains Domains validated with the DNS challenge can have an alias, so that the challenge record is created on another domain, which the '_acme-challenge' record of the domain points to with a CNAME. But the alias could only be set on the CLI, as the edit window only kept an existing one in a hidden field. Show it as a text field for domains with the DNS challenge type, like the plugin. As a side effect, an existing alias is not kept anymore when switching a domain to the HTTP challenge type with separate domain entries, like it is done in Proxmox Mail Gateway, where it has no meaning. Signed-off-by: Michal Fox --- src/window/ACMEDomains.js | 20 +++++++++++++------- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/src/window/ACMEDomains.js b/src/window/ACMEDomains.js index a2d2f83..029d427 100644 --- a/src/window/ACMEDomains.js +++ b/src/window/ACMEDomains.js @@ -142,16 +142,14 @@ Ext.define('Proxmox.window.ACMEDomainEdit', { change: function (cb, value) { let me = this; let view = me.up('pmxACMEDomainEdit'); - let pluginField = view.down('field[name=plugin]'); - pluginField.setDisabled(value !== 'dns'); - pluginField.setHidden(value !== 'dns'); + for (const name of ['plugin', 'alias']) { + let field = view.down(`field[name=${name}]`); + field.setDisabled(value !== 'dns'); + field.setHidden(value !== 'dns'); + } }, }, }, - { - xtype: 'hidden', - name: 'alias', - }, { xtype: 'pmxACMEPluginSelector', name: 'plugin', @@ -170,6 +168,14 @@ Ext.define('Proxmox.window.ACMEDomainEdit', { value: '', fieldLabel: gettext('Domain'), }, + { + xtype: 'proxmoxtextfield', + name: 'alias', + disabled: true, + hidden: true, + fieldLabel: gettext('Alias'), + emptyText: Proxmox.Utils.noneText, + }, { xtype: 'combobox', name: 'usage',