dualfroz/nikic-PHP-Parser
1
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: use PHP 8 concatenation precedence in the pretty printer

Browse Source 
The precedence table gave "." the same precedence as "+" and "-", which is
the PHP 7 ordering. PHP 8.0 lowered "." below the arithmetic and shift
operators, so printing ('abc' . 1) + 2 produced 'abc' . 1 + 2, which PHP 8
reparses as 'abc' . (1 + 2). The same applied to "-", "<<" and ">>".

The printer already targets a specific PHP version and already varies
parenthesization by version, so select the concatenation precedence the same
way: for a target of PHP 8.0 or newer, place "." between the shift operators
and the pipe operator, matching the PHP8 block of grammar/php.y. Targets below
8.0 keep the PHP 7 table, which is correct for them and produces unchanged
output.

Fixes #1041
This commit is contained in:
dualfroz committed 2026-09-03 14:09:59 +02:00
1 parent 09376a3b68
commit 00e7c77eee
4 files changed
+86 -4
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

test/code/prettyPrinter/expr/concatPrecedence.test
+55
View File
@@ -0,0 +1,55 @@
Precedence of the concatenation operator
-----
<?php
echo ('abc' . 1) + 2;
echo ('abc' . 1) - 2;
echo 2 + ('abc' . 1);
echo 'abc' . (1 + 2);
echo (1 + 2) . 'abc';
echo ('a' . 'b') << 1;
echo 'a' . (1 << 2);
echo 'a' . 'b' . 'c';
echo 'a' . ('b' . 'c');
echo ('a' . 'b') == 'c';
echo 'a' . ('b' == 'c');
-----
!!version=8.0
echo ('abc' . 1) + 2;
echo ('abc' . 1) - 2;
echo 2 + ('abc' . 1);
echo 'abc' . 1 + 2;
echo 1 + 2 . 'abc';
echo ('a' . 'b') << 1;
echo 'a' . 1 << 2;
echo 'a' . 'b' . 'c';
echo 'a' . ('b' . 'c');
echo 'a' . 'b' == 'c';
echo 'a' . ('b' == 'c');
-----
<?php
echo ('abc' . 1) + 2;
echo ('abc' . 1) - 2;
echo 2 + ('abc' . 1);
echo 'abc' . (1 + 2);
echo (1 + 2) . 'abc';
echo ('a' . 'b') << 1;
echo 'a' . (1 << 2);
echo 'a' . 'b' . 'c';
echo 'a' . ('b' . 'c');
echo ('a' . 'b') == 'c';
echo 'a' . ('b' == 'c');
-----
!!version=7.4
echo 'abc' . 1 + 2;
echo 'abc' . 1 - 2;
echo 2 + ('abc' . 1);
echo 'abc' . (1 + 2);
echo 1 + 2 . 'abc';
echo 'a' . 'b' << 1;
echo 'a' . (1 << 2);
echo 'a' . 'b' . 'c';
echo 'a' . ('b' . 'c');
echo 'a' . 'b' == 'c';
echo 'a' . ('b' == 'c');