fix: make Delorean hashable by defining __hash__

Defining __eq__ without __hash__ sets __hash__ to None in Python 3, so
Delorean instances were unhashable and could not be used in sets or as
dict keys (unlike datetime). Hash on self.epoch, the same value __eq__
compares, so equal instances hash equal.
This commit is contained in:
dualfroz committed 2026-09-06 01:10:27 +02:00
1 parent e387afcdd4
commit ad3f7e7b5d
2 files changed
+18

No files matched your search

+4
View File
@@ -240,6 +240,10 @@ class Delorean(object):
return self.epoch == other.epoch return self.epoch == other.epoch
return False return False
def __hash__(self):
# Hash on what __eq__ compares, so equal instants hash equal.
return hash(self.epoch)
def __lt__(self, other): def __lt__(self, other):
return self.epoch < other.epoch return self.epoch < other.epoch
+14
View File
@@ -50,6 +50,20 @@ class DeloreanTests(unittest.TestCase):
dt = date(2013, 5, 6) dt = date(2013, 5, 6)
self.assertRaises(ValueError, delorean.Delorean, dt) self.assertRaises(ValueError, delorean.Delorean, dt)
def test_hashable(self):
# Defining __eq__ without __hash__ makes instances unhashable in Python 3.
self.assertEqual(hash(self.do), hash(self.do))
self.assertIn(self.do, {self.do})
mapping = {self.do: "value"}
self.assertEqual(mapping[self.do], "value")
def test_hash_consistent_with_equality(self):
# Equal objects (same instant, different timezone) must hash equal.
other = self.do.shift("US/Pacific")
self.assertEqual(self.do, other)
self.assertEqual(hash(self.do), hash(other))
self.assertEqual(len({self.do, other}), 1)
def test_initialize_from_datetime_naive(self): def test_initialize_from_datetime_naive(self):
self.assertRaises( self.assertRaises(
delorean.DeloreanInvalidTimezone, delorean.Delorean, datetime=self.naive_dt delorean.DeloreanInvalidTimezone, delorean.Delorean, datetime=self.naive_dt