Remove trailing semicolon from assert_binary_snapshot! macro body

#940 removed the trailing semicolons from the serialization macro bodies but missed the two-argument arm of assert_binary_snapshot!, so calling it at the end of a block still warns with semicolon_in_expressions_from_non_local_macros on newer toolchains. this drops that semicolon and the one in test_binary.rs, so the test covers it.

CHANGELOG.md

@@ -2,6 +2,12 @@
 
 All notable changes to insta and cargo-insta are documented here.
 
+## Unreleased
+
+- Remove the trailing semicolon from the `assert_binary_snapshot!` macro body,
+  which #940 missed, to avoid compiler warnings when used in expression
+  position.
+
 ## 1.49.0
 
 - Allow `Option<&OsStr>` snapshot names, such as `Path::file_name()`,

insta/src/macros.rs

@@ -409,7 +409,7 @@ macro_rules! _assert_snapshot_base {
 #[macro_export]
 macro_rules! assert_binary_snapshot {
     ($name_and_extension:expr, $value:expr $(,)?) => {
-        $crate::assert_binary_snapshot!($name_and_extension, $value, stringify!($value));
+        $crate::assert_binary_snapshot!($name_and_extension, $value, stringify!($value))
     };
 
     ($name_and_extension:expr, $value:expr, $debug_expr:expr $(,)?) => {

insta/tests/test_binary.rs

@@ -1,6 +1,6 @@
 #[test]
 fn test_binary_snapshot() {
-    insta::assert_binary_snapshot!(".txt", b"test".to_vec());
+    insta::assert_binary_snapshot!(".txt", b"test".to_vec())
 }
 
 #[test]