git: let git parse the commit.gpgsign boolean

extensions/git/src/commands.ts

@@ -2464,8 +2464,8 @@ export class CommandCenter {
 		opts.signCommit = undefined;
 
 		if (config.get<boolean>('enableCommitSigning') === true) {
-			const commitGpgSign = await repository.getConfig('commit.gpgsign');
-			opts.signCommit = /^(false|no|off|0)$/i.test(commitGpgSign) ? undefined : true;
+			const commitGpgSign = await repository.getConfig('commit.gpgsign', 'bool');
+			opts.signCommit = commitGpgSign === 'false' ? undefined : true;
 		}
 
 		if (config.get<boolean>('alwaysSignOff')) {

extensions/git/src/git.ts

@@ -1411,13 +1411,17 @@ export class Repository {
 		return this.git.spawn(args, options);
 	}
 
-	async config(command: string, scope: string, key: string, value: any = null, options: SpawnOptions = {}): Promise<string> {
+	async config(command: string, scope: string, key: string, value: any = null, options: SpawnOptions = {}, type?: string): Promise<string> {
 		const args = ['config', `--${command}`];
 
 		if (scope) {
 			args.push(`--${scope}`);
 		}
 
+		if (type) {
+			args.push(`--${type}`);
+		}
+
 		args.push(key);
 
 		if (value) {

extensions/git/src/repository.ts

@@ -1146,8 +1146,8 @@ export class Repository implements Disposable {
 		return this.run(Operation.Config(true), () => this.repository.getConfigs('local'));
 	}
 
-	getConfig(key: string): Promise<string> {
-		return this.run(Operation.Config(true), () => this.repository.config('get', 'local', key));
+	getConfig(key: string, type?: string): Promise<string> {
+		return this.run(Operation.Config(true), () => this.repository.config('get', 'local', key, null, {}, type));
 	}
 
 	getGlobalConfig(key: string): Promise<string> {