dualfroz/gookit-config
1
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(read): prevent panic on negative slice index in a key path

Browse Source 
GetValue and Exists validated only the upper bound of a numeric key-path
segment, so a negative index such as "arr.-1" passed the check and indexed
the slice with -1, causing an index-out-of-range panic. Add a lower-bound
check (i < 0) to the []int, []string and []any cases in both functions.
This commit is contained in:
dualfroz committed 2026-09-06 00:44:38 +02:00
1 parent d54d79012b
commit cb6b9f9456
3 files changed
+29 -8
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

read.go
+6 -6
View File
@@ -63,19 +63,19 @@ func (c *Config) Exists(key string, findByPath ...bool) (ok bool) {
}
case []int: // is array(is from Set)
i, err := strconv.Atoi(k)
if err != nil || i >= len(typeData) {
if err != nil || i < 0 || i >= len(typeData) {
return false
}
item = typeData[i]
case []string: // is array(is from Set)
i, err := strconv.Atoi(k)
if err != nil || i >= len(typeData) {
if err != nil || i < 0 || i >= len(typeData) {
return false
}
item = typeData[i]
case []any: // is array(load from file)
i, err := strconv.Atoi(k)
if err != nil || i >= len(typeData) {
if err != nil || i < 0 || i >= len(typeData) {
return false
}
item = typeData[i]
@@ -214,7 +214,7 @@ func (c *Config) GetValue(key string, findByPath ...bool) (value any, ok bool) {
i, err := strconv.Atoi(k)
// check slice index
if err != nil || len(typeData) <= i {
if err != nil || i < 0 || len(typeData) <= i {
ok = false
c.addError(err)
return
@@ -223,7 +223,7 @@ func (c *Config) GetValue(key string, findByPath ...bool) (value any, ok bool) {
item = typeData[i]
case []string: // is array(is from Set)
i, err := strconv.Atoi(k)
if err != nil || len(typeData) <= i {
if err != nil || i < 0 || len(typeData) <= i {
ok = false
c.addError(err)
return
@@ -232,7 +232,7 @@ func (c *Config) GetValue(key string, findByPath ...bool) (value any, ok bool) {
item = typeData[i]
case []any: // is array(load from file)
i, err := strconv.Atoi(k)
if err != nil || len(typeData) <= i {
if err != nil || i < 0 || len(typeData) <= i {
ok = false
c.addError(err)
return