dualfroz/briannesbitt-Carbon
1
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add #[NoDiscard] to CarbonImmutable modify(), next(), previous() and __call()

Browse Source 
On PHP 8.5, DateTimeImmutable::modify() warns when its result is
discarded, but CarbonImmutable overrides it and lost the attribute.
Override modify(), next(), previous() and __call() in CarbonImmutable
with #[NoDiscard] so a discarded result warns again. The attribute is
ignored on older PHP versions, and mutable Carbon is unchanged.

Existing immutable tests that discarded results now keep them; in
IsTest::testIsSameMonth this was a real slip, the loop never moved $dt.

Fixes #3377
This commit is contained in:
dualfroz committed 2026-10-03 02:24:35 +02:00
1 parent 8dc8cfa977
commit b3fc145df6
9 files changed
+143 -11
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

tests/CarbonImmutable/DiffTest.php
+2 -2
View File
@@ -1686,7 +1686,7 @@ class DiffTest extends AbstractTestCase
{
$from = Carbon::parse('2021-03-27 20:00 Europe/Warsaw');
$to = Carbon::parse('2021-03-27 20:00 Europe/London');
$from->floatDiffInRealDays($to);
$diff = $from->floatDiffInRealDays($to);
$this->assertSame('2021-03-27 20:00:00 Europe/Warsaw', $from->format('Y-m-d H:i:s e'));
$this->assertSame('2021-03-27 20:00:00 Europe/London', $to->format('Y-m-d H:i:s e'));
@@ -1751,7 +1751,7 @@ class DiffTest extends AbstractTestCase
{
$from = Carbon::parse('2021-03-27 20:00 Europe/Warsaw');
$to = Carbon::parse('2021-03-27 20:00 Europe/London');
$from->floatDiffInUtcDays($to);
$diff = $from->floatDiffInUtcDays($to);
$this->assertSame('2021-03-27 20:00:00 Europe/Warsaw', $from->format('Y-m-d H:i:s e'));
$this->assertSame('2021-03-27 20:00:00 Europe/London', $to->format('Y-m-d H:i:s e'));