Upstream andialbrecht/sqlparse state of the touched files before 730ddba559

tests/test_grouping.py

@@ -0,0 +1,687 @@
+import pytest
+
+import sqlparse
+from sqlparse import sql, tokens as T
+
+
+def test_grouping_parenthesis():
+    s = 'select (select (x3) x2) and (y2) bar'
+    parsed = sqlparse.parse(s)[0]
+    assert str(parsed) == s
+    assert len(parsed.tokens) == 7
+    assert isinstance(parsed.tokens[2], sql.Parenthesis)
+    assert isinstance(parsed.tokens[-1], sql.Identifier)
+    assert len(parsed.tokens[2].tokens) == 5
+    assert isinstance(parsed.tokens[2].tokens[3], sql.Identifier)
+    assert isinstance(parsed.tokens[2].tokens[3].tokens[0], sql.Parenthesis)
+    assert len(parsed.tokens[2].tokens[3].tokens) == 3
+
+
+@pytest.mark.parametrize('s', ['foo := 1;', 'foo := 1'])
+def test_grouping_assignment(s):
+    parsed = sqlparse.parse(s)[0]
+    assert len(parsed.tokens) == 1
+    assert isinstance(parsed.tokens[0], sql.Assignment)
+
+
+@pytest.mark.parametrize('s', ["x > DATE '2020-01-01'", "x > TIMESTAMP '2020-01-01 00:00:00'"])
+def test_grouping_typed_literal(s):
+    parsed = sqlparse.parse(s)[0]
+    assert isinstance(parsed[0][4], sql.TypedLiteral)
+
+
+@pytest.mark.parametrize('s, a, b', [
+    ('select a from b where c < d + e', sql.Identifier, sql.Identifier),
+    ('select a from b where c < d + interval \'1 day\'', sql.Identifier, sql.TypedLiteral),
+    ('select a from b where c < d + interval \'6\' month', sql.Identifier, sql.TypedLiteral),
+    ('select a from b where c < current_timestamp - interval \'1 day\'', sql.Token, sql.TypedLiteral),
+])
+def test_compare_expr(s, a, b):
+    parsed = sqlparse.parse(s)[0]
+    assert str(parsed) == s
+    assert isinstance(parsed.tokens[2], sql.Identifier)
+    assert isinstance(parsed.tokens[6], sql.Identifier)
+    assert isinstance(parsed.tokens[8], sql.Where)
+    assert len(parsed.tokens) == 9
+    where = parsed.tokens[8]
+    assert isinstance(where.tokens[2], sql.Comparison)
+    assert len(where.tokens) == 3
+    comparison = where.tokens[2]
+    assert isinstance(comparison.tokens[0], sql.Identifier)
+    assert comparison.tokens[2].ttype is T.Operator.Comparison
+    assert isinstance(comparison.tokens[4], sql.Operation)
+    assert len(comparison.tokens) == 5
+    operation = comparison.tokens[4]
+    assert isinstance(operation.tokens[0], a)
+    assert operation.tokens[2].ttype is T.Operator
+    assert isinstance(operation.tokens[4], b)
+    assert len(operation.tokens) == 5
+
+
+def test_grouping_identifiers():
+    s = 'select foo.bar from "myscheme"."table" where fail. order'
+    parsed = sqlparse.parse(s)[0]
+    assert str(parsed) == s
+    assert isinstance(parsed.tokens[2], sql.Identifier)
+    assert isinstance(parsed.tokens[6], sql.Identifier)
+    assert isinstance(parsed.tokens[8], sql.Where)
+    s = 'select * from foo where foo.id = 1'
+    parsed = sqlparse.parse(s)[0]
+    assert str(parsed) == s
+    assert isinstance(parsed.tokens[-1].tokens[-1].tokens[0], sql.Identifier)
+    s = 'select * from (select "foo"."id" from foo)'
+    parsed = sqlparse.parse(s)[0]
+    assert str(parsed) == s
+    assert isinstance(parsed.tokens[-1].tokens[3], sql.Identifier)
+
+    for s in ["INSERT INTO `test` VALUES('foo', 'bar');",
+              "INSERT INTO `test` VALUES(1, 2), (3, 4), (5, 6);",
+              "INSERT INTO `test(a, b)` VALUES(1, 2), (3, 4), (5, 6);"]:
+        parsed = sqlparse.parse(s)[0]
+        types = [l.ttype for l in parsed.tokens if not l.is_whitespace]
+        assert types == [T.DML, T.Keyword, None, None, T.Punctuation]
+        assert isinstance(parsed.tokens[6], sql.Values)
+
+    s = "select 1.0*(a+b) as col, sum(c)/sum(d) from myschema.mytable"
+    parsed = sqlparse.parse(s)[0]
+    assert len(parsed.tokens) == 7
+    assert isinstance(parsed.tokens[2], sql.IdentifierList)
+    assert len(parsed.tokens[2].tokens) == 4
+    identifiers = list(parsed.tokens[2].get_identifiers())
+    assert len(identifiers) == 2
+    assert identifiers[0].get_alias() == "col"
+
+
+@pytest.mark.parametrize('s', [
+    '1 as f',
+    'foo as f',
+    'foo f',
+    '1/2 as f',
+    '1/2 f',
+    '1<2 as f',  # issue327
+    '1<2 f',
+])
+def test_simple_identifiers(s):
+    parsed = sqlparse.parse(s)[0]
+    assert isinstance(parsed.tokens[0], sql.Identifier)
+
+
+@pytest.mark.parametrize('s', [
+    'foo, bar',
+    'sum(a), sum(b)',
+    'sum(a) as x, b as y',
+    'sum(a)::integer, b',
+    'sum(a)/count(b) as x, y',
+    'sum(a)::integer as x, y',
+    'sum(a)::integer/count(b) as x, y',  # issue297
+])
+def test_group_identifier_list(s):
+    parsed = sqlparse.parse(s)[0]
+    assert isinstance(parsed.tokens[0], sql.IdentifierList)
+
+
+def test_grouping_identifier_wildcard():
+    p = sqlparse.parse('a.*, b.id')[0]
+    assert isinstance(p.tokens[0], sql.IdentifierList)
+    assert isinstance(p.tokens[0].tokens[0], sql.Identifier)
+    assert isinstance(p.tokens[0].tokens[-1], sql.Identifier)
+
+
+def test_grouping_identifier_name_wildcard():
+    p = sqlparse.parse('a.*')[0]
+    t = p.tokens[0]
+    assert t.get_name() == '*'
+    assert t.is_wildcard() is True
+
+
+def test_grouping_identifier_invalid():
+    p = sqlparse.parse('a.')[0]
+    assert isinstance(p.tokens[0], sql.Identifier)
+    assert p.tokens[0].has_alias() is False
+    assert p.tokens[0].get_name() is None
+    assert p.tokens[0].get_real_name() is None
+    assert p.tokens[0].get_parent_name() == 'a'
+
+
+def test_grouping_identifier_invalid_in_middle():
+    # issue261
+    s = 'SELECT foo. FROM foo'
+    p = sqlparse.parse(s)[0]
+    assert isinstance(p[2], sql.Identifier)
+    assert p[2][1].ttype == T.Punctuation
+    assert p[3].ttype == T.Whitespace
+    assert str(p[2]) == 'foo.'
+
+@pytest.mark.parametrize('s', ['foo as (select *)', 'foo as(select *)'])
+def test_grouping_identifer_as(s):
+    # issue507
+    p = sqlparse.parse(s)[0]
+    assert isinstance(p.tokens[0], sql.Identifier)
+    token = p.tokens[0].tokens[2]
+    assert token.ttype == T.Keyword
+    assert token.normalized == 'AS'
+
+def test_grouping_identifier_as_invalid():
+    # issue8
+    p = sqlparse.parse('foo as select *')[0]
+    assert len(p.tokens), 5
+    assert isinstance(p.tokens[0], sql.Identifier)
+    assert len(p.tokens[0].tokens) == 1
+    assert p.tokens[2].ttype == T.Keyword
+
+
+def test_grouping_identifier_function():
+    p = sqlparse.parse('foo() as bar')[0]
+    assert isinstance(p.tokens[0], sql.Identifier)
+    assert isinstance(p.tokens[0].tokens[0], sql.Function)
+    p = sqlparse.parse('foo()||col2 bar')[0]
+    assert isinstance(p.tokens[0], sql.Identifier)
+    assert isinstance(p.tokens[0].tokens[0], sql.Operation)
+    assert isinstance(p.tokens[0].tokens[0].tokens[0], sql.Function)
+    p = sqlparse.parse('foo(c1) over win1 as bar')[0]
+    assert isinstance(p.tokens[0], sql.Identifier)
+    assert isinstance(p.tokens[0].tokens[0], sql.Function)
+    assert len(p.tokens[0].tokens[0].tokens) == 4
+    assert isinstance(p.tokens[0].tokens[0].tokens[3], sql.Over)
+    assert isinstance(p.tokens[0].tokens[0].tokens[3].tokens[2],
+                      sql.Identifier)
+    p = sqlparse.parse('foo(c1) over (partition by c2 order by c3) as bar')[0]
+    assert isinstance(p.tokens[0], sql.Identifier)
+    assert isinstance(p.tokens[0].tokens[0], sql.Function)
+    assert len(p.tokens[0].tokens[0].tokens) == 4
+    assert isinstance(p.tokens[0].tokens[0].tokens[3], sql.Over)
+    assert isinstance(p.tokens[0].tokens[0].tokens[3].tokens[2],
+                      sql.Parenthesis)
+
+
+@pytest.mark.parametrize('s', ['foo+100', 'foo + 100', 'foo*100'])
+def test_grouping_operation(s):
+    p = sqlparse.parse(s)[0]
+    assert isinstance(p.tokens[0], sql.Operation)
+
+
+def test_grouping_identifier_list():
+    p = sqlparse.parse('a, b, c')[0]
+    assert isinstance(p.tokens[0], sql.IdentifierList)
+    p = sqlparse.parse('(a, b, c)')[0]
+    assert isinstance(p.tokens[0].tokens[1], sql.IdentifierList)
+
+
+def test_grouping_identifier_list_subquery():
+    """identifier lists should still work in subqueries with aliases"""
+    p = sqlparse.parse("select * from ("
+                       "select a, b + c as d from table) sub")[0]
+    subquery = p.tokens[-1].tokens[0]
+    idx, iden_list = subquery.token_next_by(i=sql.IdentifierList)
+    assert iden_list is not None
+    # all the identifiers should be within the IdentifierList
+    _, ilist = subquery.token_next_by(i=sql.Identifier, idx=idx)
+    assert ilist is None
+
+
+def test_grouping_identifier_list_case():
+    p = sqlparse.parse('a, case when 1 then 2 else 3 end as b, c')[0]
+    assert isinstance(p.tokens[0], sql.IdentifierList)
+    p = sqlparse.parse('(a, case when 1 then 2 else 3 end as b, c)')[0]
+    assert isinstance(p.tokens[0].tokens[1], sql.IdentifierList)
+
+
+def test_grouping_identifier_list_other():
+    # issue2
+    p = sqlparse.parse("select *, null, 1, 'foo', bar from mytable, x")[0]
+    assert isinstance(p.tokens[2], sql.IdentifierList)
+    assert len(p.tokens[2].tokens) == 13
+
+
+def test_grouping_identifier_list_with_inline_comments():
+    # issue163
+    p = sqlparse.parse('foo /* a comment */, bar')[0]
+    assert isinstance(p.tokens[0], sql.IdentifierList)
+    assert isinstance(p.tokens[0].tokens[0], sql.Identifier)
+    assert isinstance(p.tokens[0].tokens[3], sql.Identifier)
+
+
+def test_grouping_identifiers_with_operators():
+    p = sqlparse.parse('a+b as c from table where (d-e)%2= 1')[0]
+    assert len([x for x in p.flatten() if x.ttype == T.Name]) == 5
+
+
+def test_grouping_identifier_list_with_order():
+    # issue101
+    p = sqlparse.parse('1, 2 desc, 3')[0]
+    assert isinstance(p.tokens[0], sql.IdentifierList)
+    assert isinstance(p.tokens[0].tokens[3], sql.Identifier)
+    assert str(p.tokens[0].tokens[3]) == '2 desc'
+
+
+def test_grouping_nested_identifier_with_order():
+    # issue745
+    p = sqlparse.parse('(a desc)')[0]
+    assert isinstance(p.tokens[0], sql.Parenthesis)
+    assert isinstance(p.tokens[0].tokens[1], sql.Identifier)
+    assert str(p.tokens[0].tokens[1]) == 'a desc'
+
+
+def test_grouping_where():
+    s = 'select * from foo where bar = 1 order by id desc'
+    p = sqlparse.parse(s)[0]
+    assert str(p) == s
+    assert len(p.tokens) == 12
+
+    s = 'select x from (select y from foo where bar = 1) z'
+    p = sqlparse.parse(s)[0]
+    assert str(p) == s
+    assert isinstance(p.tokens[-1].tokens[0].tokens[-2], sql.Where)
+
+
+@pytest.mark.parametrize('s', (
+    'select 1 where 1 = 2 union select 2',
+    'select 1 where 1 = 2 union all select 2',
+))
+def test_grouping_where_union(s):
+    p = sqlparse.parse(s)[0]
+    assert p.tokens[5].value.startswith('union')
+
+
+def test_returning_kw_ends_where_clause():
+    s = 'delete from foo where x > y returning z'
+    p = sqlparse.parse(s)[0]
+    assert isinstance(p.tokens[6], sql.Where)
+    assert p.tokens[7].ttype == T.Keyword
+    assert p.tokens[7].value == 'returning'
+
+
+def test_into_kw_ends_where_clause():  # issue324
+    s = 'select * from foo where a = 1 into baz'
+    p = sqlparse.parse(s)[0]
+    assert isinstance(p.tokens[8], sql.Where)
+    assert p.tokens[9].ttype == T.Keyword
+    assert p.tokens[9].value == 'into'
+
+
+@pytest.mark.parametrize('sql, expected', [
+    # note: typecast needs to be 2nd token for this test
+    ('select foo::integer from bar', 'integer'),
+    ('select (current_database())::information_schema.sql_identifier',
+     'information_schema.sql_identifier'),
+])
+def test_grouping_typecast(sql, expected):
+    p = sqlparse.parse(sql)[0]
+    assert p.tokens[2].get_typecast() == expected
+
+
+def test_grouping_alias():
+    s = 'select foo as bar from mytable'
+    p = sqlparse.parse(s)[0]
+    assert str(p) == s
+    assert p.tokens[2].get_real_name() == 'foo'
+    assert p.tokens[2].get_alias() == 'bar'
+    s = 'select foo from mytable t1'
+    p = sqlparse.parse(s)[0]
+    assert str(p) == s
+    assert p.tokens[6].get_real_name() == 'mytable'
+    assert p.tokens[6].get_alias() == 't1'
+    s = 'select foo::integer as bar from mytable'
+    p = sqlparse.parse(s)[0]
+    assert str(p) == s
+    assert p.tokens[2].get_alias() == 'bar'
+    s = ('SELECT DISTINCT '
+         '(current_database())::information_schema.sql_identifier AS view')
+    p = sqlparse.parse(s)[0]
+    assert str(p) == s
+    assert p.tokens[4].get_alias() == 'view'
+
+
+def test_grouping_alias_case():
+    # see issue46
+    p = sqlparse.parse('CASE WHEN 1 THEN 2 ELSE 3 END foo')[0]
+    assert len(p.tokens) == 1
+    assert p.tokens[0].get_alias() == 'foo'
+
+
+def test_grouping_alias_ctas():
+    p = sqlparse.parse('CREATE TABLE tbl1 AS SELECT coalesce(t1.col1, 0) AS col1 FROM t1')[0]
+    assert p.tokens[10].get_alias() == 'col1'
+    assert isinstance(p.tokens[10].tokens[0], sql.Function)
+
+
+def test_grouping_alias_ctas_lowercase_as():
+    # 'as' is case-insensitive; a lowercase keyword in CREATE TABLE ... AS
+    # SELECT must not disable function grouping in the SELECT body.
+    p = sqlparse.parse('create table tbl1 as select coalesce(t1.col1, 0) as col1 from t1')[0]
+    assert p.tokens[10].get_alias() == 'col1'
+    assert isinstance(p.tokens[10].tokens[0], sql.Function)
+
+def test_grouping_subquery_no_parens():
+    # Not totally sure if this is the right approach...
+    # When a THEN clause contains a subquery w/o parenthesis around it *and*
+    # a WHERE condition, the WHERE grouper consumes END too.
+    # This takes makes sure that it doesn't fail.
+    p = sqlparse.parse('CASE WHEN 1 THEN select 2 where foo = 1 end')[0]
+    assert len(p.tokens) == 1
+    assert isinstance(p.tokens[0], sql.Case)
+
+
+@pytest.mark.parametrize('s', ['foo.bar', 'x, y', 'x > y', 'x / y'])
+def test_grouping_alias_returns_none(s):
+    # see issue185 and issue445
+    p = sqlparse.parse(s)[0]
+    assert len(p.tokens) == 1
+    assert p.tokens[0].get_alias() is None
+
+
+def test_grouping_idlist_function():
+    # see issue10 too
+    p = sqlparse.parse('foo(1) x, bar')[0]
+    assert isinstance(p.tokens[0], sql.IdentifierList)
+
+
+def test_grouping_comparison_exclude():
+    # make sure operators are not handled too lazy
+    p = sqlparse.parse('(=)')[0]
+    assert isinstance(p.tokens[0], sql.Parenthesis)
+    assert not isinstance(p.tokens[0].tokens[1], sql.Comparison)
+    p = sqlparse.parse('(a=1)')[0]
+    assert isinstance(p.tokens[0].tokens[1], sql.Comparison)
+    p = sqlparse.parse('(a>=1)')[0]
+    assert isinstance(p.tokens[0].tokens[1], sql.Comparison)
+
+
+def test_grouping_function():
+    p = sqlparse.parse('foo()')[0]
+    assert isinstance(p.tokens[0], sql.Function)
+    p = sqlparse.parse('foo(null, bar)')[0]
+    assert isinstance(p.tokens[0], sql.Function)
+    assert len(list(p.tokens[0].get_parameters())) == 2
+    p = sqlparse.parse('foo(5) over win1')[0]
+    assert isinstance(p.tokens[0], sql.Function)
+    assert len(list(p.tokens[0].get_parameters())) == 1
+    assert isinstance(p.tokens[0].get_window(), sql.Identifier)
+    p = sqlparse.parse('foo(5) over (PARTITION BY c1)')[0]
+    assert isinstance(p.tokens[0], sql.Function)
+    assert len(list(p.tokens[0].get_parameters())) == 1
+    assert isinstance(p.tokens[0].get_window(), sql.Parenthesis)
+
+
+def test_grouping_function_not_in():
+    # issue183
+    p = sqlparse.parse('in(1, 2)')[0]
+    assert len(p.tokens) == 2
+    assert p.tokens[0].ttype == T.Keyword
+    assert isinstance(p.tokens[1], sql.Parenthesis)
+
+
+def test_grouping_varchar():
+    p = sqlparse.parse('"text" Varchar(50) NOT NULL')[0]
+    assert isinstance(p.tokens[2], sql.Function)
+
+
+def test_statement_get_type():
+    def f(sql):
+        return sqlparse.parse(sql)[0]
+
+    assert f('select * from foo').get_type() == 'SELECT'
+    assert f('update foo').get_type() == 'UPDATE'
+    assert f(' update foo').get_type() == 'UPDATE'
+    assert f('\nupdate foo').get_type() == 'UPDATE'
+    assert f('foo').get_type() == 'UNKNOWN'
+
+
+def test_identifier_with_operators():
+    # issue 53
+    p = sqlparse.parse('foo||bar')[0]
+    assert len(p.tokens) == 1
+    assert isinstance(p.tokens[0], sql.Operation)
+    # again with whitespaces
+    p = sqlparse.parse('foo || bar')[0]
+    assert len(p.tokens) == 1
+    assert isinstance(p.tokens[0], sql.Operation)
+
+
+def test_identifier_with_op_trailing_ws():
+    # make sure trailing whitespace isn't grouped with identifier
+    p = sqlparse.parse('foo || bar ')[0]
+    assert len(p.tokens) == 2
+    assert isinstance(p.tokens[0], sql.Operation)
+    assert p.tokens[1].ttype is T.Whitespace
+
+
+def test_identifier_with_string_literals():
+    p = sqlparse.parse("foo + 'bar'")[0]
+    assert len(p.tokens) == 1
+    assert isinstance(p.tokens[0], sql.Operation)
+
+
+# This test seems to be wrong. It was introduced when fixing #53, but #111
+# showed that this shouldn't be an identifier at all. I'm leaving this
+# commented in the source for a while.
+# def test_identifier_string_concat():
+#     p = sqlparse.parse("'foo' || bar")[0]
+#     assert len(p.tokens) == 1
+#     assert isinstance(p.tokens[0], sql.Identifier)
+
+
+def test_identifier_consumes_ordering():
+    # issue89
+    p = sqlparse.parse('select * from foo order by c1 desc, c2, c3')[0]
+    assert isinstance(p.tokens[-1], sql.IdentifierList)
+    ids = list(p.tokens[-1].get_identifiers())
+    assert len(ids) == 3
+    assert ids[0].get_name() == 'c1'
+    assert ids[0].get_ordering() == 'DESC'
+    assert ids[1].get_name() == 'c2'
+    assert ids[1].get_ordering() is None
+
+
+def test_comparison_with_keywords():
+    # issue90
+    # in fact these are assignments, but for now we don't distinguish them
+    p = sqlparse.parse('foo = NULL')[0]
+    assert len(p.tokens) == 1
+    assert isinstance(p.tokens[0], sql.Comparison)
+    assert len(p.tokens[0].tokens) == 5
+    assert p.tokens[0].left.value == 'foo'
+    assert p.tokens[0].right.value == 'NULL'
+    # make sure it's case-insensitive
+    p = sqlparse.parse('foo = null')[0]
+    assert len(p.tokens) == 1
+    assert isinstance(p.tokens[0], sql.Comparison)
+
+
+def test_comparison_with_floats():
+    # issue145
+    p = sqlparse.parse('foo = 25.5')[0]
+    assert len(p.tokens) == 1
+    assert isinstance(p.tokens[0], sql.Comparison)
+    assert len(p.tokens[0].tokens) == 5
+    assert p.tokens[0].left.value == 'foo'
+    assert p.tokens[0].right.value == '25.5'
+
+
+def test_comparison_with_parenthesis():
+    # issue23
+    p = sqlparse.parse('(3 + 4) = 7')[0]
+    assert len(p.tokens) == 1
+    assert isinstance(p.tokens[0], sql.Comparison)
+    comp = p.tokens[0]
+    assert isinstance(comp.left, sql.Parenthesis)
+    assert comp.right.ttype is T.Number.Integer
+
+
+@pytest.mark.parametrize('operator', (
+    '=', '!=', '>', '<', '<=', '>=', '~', '~~', '!~~',
+    'LIKE', 'NOT LIKE', 'ILIKE', 'NOT ILIKE',
+))
+def test_comparison_with_strings(operator):
+    # issue148
+    p = sqlparse.parse(f"foo {operator} 'bar'")[0]
+    assert len(p.tokens) == 1
+    assert isinstance(p.tokens[0], sql.Comparison)
+    assert p.tokens[0].right.value == "'bar'"
+    assert p.tokens[0].right.ttype == T.String.Single
+
+
+def test_like_and_ilike_comparison():
+    def validate_where_clause(where_clause, expected_tokens):
+        assert len(where_clause.tokens) == len(expected_tokens)
+        for where_token, expected_token in zip(where_clause, expected_tokens):
+            expected_ttype, expected_value = expected_token
+            if where_token.ttype is not None:
+                assert where_token.match(expected_ttype, expected_value, regex=True)
+            else:
+                # Certain tokens, such as comparison tokens, do not define a ttype that can be
+                # matched against. For these tokens, we ensure that the token instance is of
+                # the expected type and has a value conforming to specified regular expression
+                import re
+                assert (isinstance(where_token, expected_ttype)
+                        and re.match(expected_value, where_token.value))
+
+    [p1] = sqlparse.parse("select * from mytable where mytable.mycolumn LIKE 'expr%' limit 5;")
+    [p1_where] = [token for token in p1 if isinstance(token, sql.Where)]
+    validate_where_clause(p1_where, [
+        (T.Keyword, "where"),
+        (T.Whitespace, None),
+        (sql.Comparison, r"mytable.mycolumn LIKE.*"),
+        (T.Whitespace, None),
+    ])
+
+    [p2] = sqlparse.parse(
+        "select * from mytable where mycolumn NOT ILIKE '-expr' group by othercolumn;")
+    [p2_where] = [token for token in p2 if isinstance(token, sql.Where)]
+    validate_where_clause(p2_where, [
+        (T.Keyword, "where"),
+        (T.Whitespace, None),
+        (sql.Comparison, r"mycolumn NOT ILIKE.*"),
+        (T.Whitespace, None),
+    ])
+
+
+def test_comparison_with_functions():
+    # issue230
+    p = sqlparse.parse('foo = DATE(bar.baz)')[0]
+    assert len(p.tokens) == 1
+    assert isinstance(p.tokens[0], sql.Comparison)
+    assert len(p.tokens[0].tokens) == 5
+    assert p.tokens[0].left.value == 'foo'
+    assert p.tokens[0].right.value == 'DATE(bar.baz)'
+
+    p = sqlparse.parse('DATE(foo.bar) = DATE(bar.baz)')[0]
+    assert len(p.tokens) == 1
+    assert isinstance(p.tokens[0], sql.Comparison)
+    assert len(p.tokens[0].tokens) == 5
+    assert p.tokens[0].left.value == 'DATE(foo.bar)'
+    assert p.tokens[0].right.value == 'DATE(bar.baz)'
+
+    p = sqlparse.parse('DATE(foo.bar) = bar.baz')[0]
+    assert len(p.tokens) == 1
+    assert isinstance(p.tokens[0], sql.Comparison)
+    assert len(p.tokens[0].tokens) == 5
+    assert p.tokens[0].left.value == 'DATE(foo.bar)'
+    assert p.tokens[0].right.value == 'bar.baz'
+
+
+def test_comparison_with_typed_literal():
+    p = sqlparse.parse("foo = DATE 'bar.baz'")[0]
+    assert len(p.tokens) == 1
+    comp = p.tokens[0]
+    assert isinstance(comp, sql.Comparison)
+    assert len(comp.tokens) == 5
+    assert comp.left.value == 'foo'
+    assert isinstance(comp.right, sql.TypedLiteral)
+    assert comp.right.value == "DATE 'bar.baz'"
+
+
+@pytest.mark.parametrize('start', ['FOR', 'FOREACH'])
+def test_forloops(start):
+    p = sqlparse.parse(f'{start} foo in bar LOOP foobar END LOOP')[0]
+    assert (len(p.tokens)) == 1
+    assert isinstance(p.tokens[0], sql.For)
+
+
+def test_nested_for():
+    p = sqlparse.parse('FOR foo LOOP FOR bar LOOP END LOOP END LOOP')[0]
+    assert len(p.tokens) == 1
+    for1 = p.tokens[0]
+    assert for1.tokens[0].value == 'FOR'
+    assert for1.tokens[-1].value == 'END LOOP'
+    for2 = for1.tokens[6]
+    assert isinstance(for2, sql.For)
+    assert for2.tokens[0].value == 'FOR'
+    assert for2.tokens[-1].value == 'END LOOP'
+
+
+def test_begin():
+    p = sqlparse.parse('BEGIN foo END')[0]
+    assert len(p.tokens) == 1
+    assert isinstance(p.tokens[0], sql.Begin)
+
+
+def test_keyword_followed_by_parenthesis():
+    p = sqlparse.parse('USING(somecol')[0]
+    assert len(p.tokens) == 3
+    assert p.tokens[0].ttype == T.Keyword
+    assert p.tokens[1].ttype == T.Punctuation
+
+
+def test_nested_begin():
+    p = sqlparse.parse('BEGIN foo BEGIN bar END END')[0]
+    assert len(p.tokens) == 1
+    outer = p.tokens[0]
+    assert outer.tokens[0].value == 'BEGIN'
+    assert outer.tokens[-1].value == 'END'
+    inner = outer.tokens[4]
+    assert inner.tokens[0].value == 'BEGIN'
+    assert inner.tokens[-1].value == 'END'
+    assert isinstance(inner, sql.Begin)
+
+
+def test_aliased_column_without_as():
+    p = sqlparse.parse('foo bar')[0].tokens
+    assert len(p) == 1
+    assert p[0].get_real_name() == 'foo'
+    assert p[0].get_alias() == 'bar'
+
+    p = sqlparse.parse('foo.bar baz')[0].tokens[0]
+    assert p.get_parent_name() == 'foo'
+    assert p.get_real_name() == 'bar'
+    assert p.get_alias() == 'baz'
+
+
+def test_qualified_function():
+    p = sqlparse.parse('foo()')[0].tokens[0]
+    assert p.get_parent_name() is None
+    assert p.get_real_name() == 'foo'
+
+    p = sqlparse.parse('foo.bar()')[0].tokens[0]
+    assert p.get_parent_name() == 'foo'
+    assert p.get_real_name() == 'bar'
+
+
+def test_aliased_function_without_as():
+    p = sqlparse.parse('foo() bar')[0].tokens[0]
+    assert p.get_parent_name() is None
+    assert p.get_real_name() == 'foo'
+    assert p.get_alias() == 'bar'
+
+    p = sqlparse.parse('foo.bar() baz')[0].tokens[0]
+    assert p.get_parent_name() == 'foo'
+    assert p.get_real_name() == 'bar'
+    assert p.get_alias() == 'baz'
+
+
+def test_aliased_literal_without_as():
+    p = sqlparse.parse('1 foo')[0].tokens
+    assert len(p) == 1
+    assert p[0].get_alias() == 'foo'
+
+
+def test_grouping_as_cte():
+    p = sqlparse.parse('foo AS WITH apple AS 1, banana AS 2')[0].tokens
+    assert len(p) > 4
+    assert p[0].get_alias() is None
+    assert p[2].value == 'AS'
+    assert p[4].value == 'WITH'
+
+def test_grouping_create_table():
+    p = sqlparse.parse("create table db.tbl (a string)")[0].tokens
+    assert p[4].value == "db.tbl"