Allow merged indexes to be marked optional

A merged index that failed to load made mergeIndex throw, and the failed instance stayed in the list, so search stopped working for every index. Indexes passed with `optional: true` are now dropped with a warning when they fail to load, and search runs over the indexes that did load. Fixes #887
2026-10-03 01:37:54 +02:00
1 parent ebcea5d0cb
commit b572112ae7
@@ -0,0 +1,33 @@
+name: Multisite Search > Pagefind skips an optional index that fails to load
+steps:
+  - ref: ./background.toolproof.yml
+  - macro: I run Pagefind with "--site root/website_a"
+  - step: stdout should contain "Running Pagefind"
+  - step: The file "root/website_a/pagefind/pagefind.js" should not be empty
+  - macro: I run Pagefind with "--site root/website_b"
+  - step: stdout should contain "Running Pagefind"
+  - step: The file "root/website_b/pagefind/pagefind.js" should not be empty
+  - step: I serve the directory "root"
+  - step: In my browser, I load "/"
+  - step: In my browser, I evaluate {js}
+    js: >-
+      let pagefind = await import("/website_a/pagefind/pagefind.js");
+
+      await pagefind.mergeIndex("/website_c/pagefind/", { optional: true });
+
+      await pagefind.mergeIndex("/website_b/pagefind/");
+
+
+      let search = await pagefind.search("web");
+
+
+      let pages = await Promise.all(search.results.map(r => r.data()));
+
+      document.querySelector('[data-result]').innerText = pages.map(p =>
+      p.url).join(", ");
+  - step: In my browser, I evaluate {js}
+    js: >-
+      let val = await toolproof.querySelector("[data-result]");
+
+      toolproof.assert_eq(val.innerHTML, `/website_a/hello/,
+      /website_b/lorem/`);
@@ -0,0 +1,42 @@
+name: Multisite Search > Pagefind UI skips an optional index that fails to load
+steps:
+  - ref: ./background.toolproof.yml
+  - step: I have a "root/index.html" file with the content {html}
+    html: |-
+      <!DOCTYPE html><html lang="en"><head></head><body><div id="search"></div>
+      <script src="/website_a/pagefind/pagefind-ui.js"></script></body></html>
+  - macro: I run Pagefind with "--site root/website_a"
+  - step: stdout should contain "Running Pagefind"
+  - step: The file "root/website_a/pagefind/pagefind.js" should not be empty
+  - macro: I run Pagefind with "--site root/website_b"
+  - step: stdout should contain "Running Pagefind"
+  - step: The file "root/website_b/pagefind/pagefind.js" should not be empty
+  - step: I serve the directory "root"
+  - step: In my browser, I load "/"
+  - step: In my browser, I evaluate {js}
+    js: |-
+      let pui = new PagefindUI({
+          element: "#search",
+          mergeIndex: [{
+              bundlePath: "/website_c/pagefind/",
+              optional: true
+          }, {
+              bundlePath: "/website_b/pagefind/"
+          }]
+      });
+      pui.triggerSearch("web");
+  - step: In my browser, I evaluate {js}
+    js: >-
+      let val = await
+      toolproof.querySelector(".pagefind-ui__result:nth-of-type(1)
+      .pagefind-ui__result-link");
+
+      toolproof.assert_eq(val.innerHTML, `web web world web
+      PAGEFIND_ROOT_SELECTOR`);
+  - step: In my browser, I evaluate {js}
+    js: >-
+      let val = await
+      toolproof.querySelector(".pagefind-ui__result:nth-of-type(2)
+      .pagefind-ui__result-link");
+
+      toolproof.assert_eq(val.innerHTML, `web ipsum`);